Broken disabled HDF5 builds
fglines-nv opened this issue · 1 comments
fglines-nv commented
The latest PR was missing some #ifdef's to keep non-HDF5 builds working. when compiling with PARTHENON_DISABLE_HDF5=ON I get this error while building:
/home/scratch.fglines_gpu/projects/ats-5-benchmarks/parthenon/src/outputs/restart_hdf5.cpp: In member function 'virtual parthenon::RestartReader::MeshInfo parthenon::RestartReaderHDF5::GetMeshInfo() const':
/home/scratch.fglines_gpu/projects/ats-5-benchmarks/parthenon/src/outputs/restart_hdf5.cpp:138:38: error: 'fh_' was not declared in this scope
138 | PARTHENON_HDF5_CHECK(H5Lexists(fh_, "Blocks/derefinement_count", H5P_DEFAULT));
| ^~~
/home/scratch.fglines_gpu/projects/ats-5-benchmarks/parthenon/src/outputs/restart_hdf5.cpp:138:72: error: 'H5P_DEFAULT' was not declared in this scope; did you mean 'RTLD_DEFAULT'?
138 | PARTHENON_HDF5_CHECK(H5Lexists(fh_, "Blocks/derefinement_count", H5P_DEFAULT));
| ^~~~~~~~~~~
| RTLD_DEFAULT
/home/scratch.fglines_gpu/projects/ats-5-benchmarks/parthenon/src/outputs/restart_hdf5.cpp:138:28: error: 'H5Lexists' was not declared in this scope
138 | PARTHENON_HDF5_CHECK(H5Lexists(fh_, "Blocks/derefinement_count", H5P_DEFAULT));
| ^~~~~~~~~
/home/scratch.fglines_gpu/projects/ats-5-benchmarks/parthenon/src/outputs/restart_hdf5.cpp:138:7: error: 'PARTHENON_HDF5_CHECK' was not declared in this scope; did you mean 'PARTHENON_MPI_CHECK'?
138 | PARTHENON_HDF5_CHECK(H5Lexists(fh_, "Blocks/derefinement_count", H5P_DEFAULT));
| ^~~~~~~~~~~~~~~~~~~~
| PARTHENON_MPI_CHECK
Yurlungur commented
@fglines-nv can you try this branch? #1095