particle-iot/spark-cli

~/.spark/spark.config.json permissions

Closed this issue · 6 comments

Since the ~/.spark/spark.config.json file has an access token that allows arbitrary access to a user's cores, it should be created with an explicit 600 mode rather than using the default umask to prevent another user on the system from stealing it.

@osresearch thank you for spotting this. Great point!

@emilyrose, that will apply to new .json file creations as well since users are free to add more cloud profiles using spark config

@kennethlimcp definitely. Let me get a PR together & you can tell me what you think.

@osresearch, @kennethlimcp have a look at #149 and let me know what you think.

Not at all proficient in java/nodejs so you guys definitely make a better call :)

I forgot to tag the PR, but a fix for this has been merged. Thanks @osresearch and @kennethlimcp for weighing in!