add support for check_run, check_suite ?

Question

add support for check_run, check_suite ?

brad-decker opened this issue 5 years ago · 7 comments

I need to hook into merge when check_run or check_suite actions are called because we use circle ci with github checks and it doesn't post status updates to the commits to trigger on 'status' when this feature is enabled. Thoughts?

Answer 1 · 2019-09-20T16:59:52.000Z

Any update on this? It would be helpful for running in response to CircleCI checks.

Answer 2 · 2019-09-21T15:54:50.000Z

Sorry, I thought I had already replied!

I'm not sure about this feature: We're also using Circle CI, and when a build finished, the status event is triggered just fine. As it says in the documentation:

As an example, one common use is for continuous integration services to mark commits as passing or failing builds using status.

Answer 3 · 2019-09-21T15:56:20.000Z

By the way, I'm not against this feature. There's already a PR #8, but no reply there so far

Answer 4 · 2019-11-09T18:15:23.000Z

This still isn't fixed, but I've added this as limitation to the README for now

Answer 5 · 2020-04-01T12:49:33.000Z

I think this was fixed with #60. However, feel free to reopen this or create a new issue if you disagree or if there are any other problems! 👍

Answer 6 · 2020-04-22T11:05:32.000Z

@pascalgn For protected branches it still does not merge.

Answer 7 · 2020-04-22T13:34:22.000Z

Are you sure that's related to the check_run/check_suite events? Or is it a separate issue?