patchkit/patchkit-image-uploader

what was broken about rotation?

dominictarr opened this issue · 2 comments

pfrazee commented

I emailed a response but I'm not seeing it now.

The rotation screwed up the translation offset. It's been too long since I screwed with graphics algebra... there's a way to do translation and then rotation without things going wrong, but I couldnt sort it out.

dominictarr commented

right, that is why I was translating it to the center...
I think we could refactor this module a bit more.
it's suggest-box is really easy to reuse, and it would be good to be able to use this to resize/crop images just for when they are to go in your feed.