The Sass file _angular-patternfly.scss does not include Datepicker & Vertical-navigation

Question

The Sass file _angular-patternfly.scss does not include Datepicker & Vertical-navigation

Closed this issue 6 years ago · 5 comments

Found a bug.

In the Sass file angular-patternfly/styles/_angular-patternfly.scss - it seems to be missing datepicker and vertical-navigation imports, even though they are there in the Less file.

Answer 1 · 2019-03-12T11:59:12.000Z

Thanks @wywywywy, are you interested in contributing a fix?

Answer 2 · 2019-03-12T12:51:16.000Z

Yes sure I'll submit a PR later today.

Answer 3 · 2019-03-12T13:56:43.000Z

Thanks @wywywywy !

Answer 4 · 2019-03-12T14:14:45.000Z

Hi @wywywywy, you've probably already seen this, but if not: https://github.com/patternfly/angular-patternfly#less-to-sass-conversion

Is the issue with datepicker and vertical-navigation imports due to:

"Note: When a Less file is added/deleted/renamed it needs to be updated in the main Less import file /styles/angular-patternfly.less and the main Sass import file styles/_angular-patternfly.scss."

Thanks!

Answer 5 · 2019-03-12T15:20:22.000Z

Yes it is.

I think someone just forgot to put those 2 lines in.