Remove protected for ProgressBar methods.
jasonm23 opened this issue · 3 comments
jasonm23 commented
To help people customize/extend ProgressBar for their specific use cases, it'd be great if there was no protected method access.
I'm wondering why those methods were protected in the first place?
More than happy to submit the 1 line PR if needed. 👍🏻
jasonm23 commented
Ok, I'll admit it, I forgot that protected doesn't stop monkey patching... so closing.
paul commented
@jasonm23 What sort of customizations were you looking to do? Awhile back I hacked together a way to "theme" the bar, but never finished because it wasn't something I needed personally. #45 (comment)
jasonm23 commented
I just override render_bar and change the # to a ░
It'd be pretty easy to allow this as a user option on the script using progress_bar.