paulcwarren/ginkgo4j

Describe block with empty message does not run

danger-ranger opened this issue · 6 comments

e.g.

Describe("", () -> {
    It("stuff", () -> {
        assertThat(true).isTrue();
    });
});  

This won't run any tests

Not a big deal, it's just unexpected sometimes

So, we suspect an empty Describe label? Will fix soonest. Thx for the issue.

Yeah. It's not exactly a valid use case, but

Hey Gavin,
I started having a look at this today. When I attempt to run that test I get an IllegalArgumentException from the framework. I just wanted to check a couple of things. 1. you are seeing the same thing and 2. expected behavior from your point of view. Do you expect this to run (and obviously pass)? 3. what version of junit are you guys using there?

  1. Still seeing it, screenshots below.
  2. I would expect it to run tests whether or not some of the Describe blocks have empty messages. Failing that I would expect an error message instead of just "No tests were found"
  3. We're running ginkgo4j 1.0.7, junit 4.12

screen shot 2017-02-16 at 11 16 49 am
screen shot 2017-02-16 at 11 16 39 am

Fixed. Will be in 1.0.8