pauldotknopf/JavaScriptViewEngine

ASP.NET Core 2.0 Support?

Closed this issue · 9 comments

neodescis commented

Are there any plans to update this library to support ASP.NET Core 2.0? I downloaded the source and it looks like all that needs to be done is to use InvokeExportAsync instead of InvokeExport in NodeRenderEngine.cs, as it was renamed in INodeServices.

ensemblebd commented

did you make a fork by chance? Would be nice to test it out and see if it works.

pauldotknopf commented

Hey guys, sorry for the delay.

This project needs to be updated to the latest bits. I have been swamped currently with other work, but I will get this done this weekend.

  • 🎉1
pauldotknopf commented

Also, I would be happy to merge any pull requests you may have :)

ensemblebd commented

hooray! thank you. Can't wait to use it on latest project in 2.0

neodescis commented

Nice, thanks @ensemblebd ! Your changes are exactly what I did to get it working. I did test it out and it appears to run fine.

  • ❤️1
pauldotknopf commented

Does anybody here need the MVC5 version? I'm about to drop it.

ensemblebd commented

Not I, all good. Am trying to actively convert all systems @ job over to core, for future.
But not sure about the other peeps. Thank you again! :)

pauldotknopf commented

The new packages are pushed to NuGet. They should be indexed soon.

  • ❤️2