paulgibbs/turtleshell

Test widget area

Closed this issue · 7 comments

I've just pushed a commit that implements a widget area in the member profile area, just below the navigation. Can this please be checked to see if this is safe to include, and if it can work on most widgets?

I'm seeing problems with some of the core widgets forcing themselves to be wider than the nav menu, and overflow issues. None of which seemed to me to be quick or reliable to fix. We can revert the commit if this doesn't turn out to be a good idea.

I gave this a test and few things to report:

Edge case: https://www.evernote.com/shard/s3/sh/dbfd1c75-65ee-4cd6-9d3a-d57040897d74/feb45d4d10a96b621d253b9e7762b2fd

Not so edge case as calendar is common: https://www.evernote.com/shard/s3/sh/77d0bb7a-0912-4c4d-aab8-e04dc8de53fb/e0df76d33bc568ccff7322bb1b7f8d4b

We could add:

#bp-member-profile-widgets {
max-width: 150px;
width: 150px;
float: left;
clear: left;
}

That seems the issue from just fiddling a little with the CSS. That or put a wrapper around the menu and widget area to create an inner sidebar and then float that. If we're not having stalking menu could work. The above solution though needs some polish for the margins / calendar widget but it's a starting suggestion.

Ultimately I like the idea of a widget area there - it seems an excellent fit so if we can work out a method that it works with I think it would be an asset to have.

The #wp-calendar is still wider than its parent, #calendar_wrap. Is this just the paddings on the table cells on the calendar widget specifically?

I think it's the paddings we could do a #sidebarselector #wpcalendar fix.

Sounds awfully granular and not reliable. Interestingly enough, the box model we're using for this gives an interesting option if we remove the width restriction: http://cl.ly/image/3X3V1A1o2g3R

Hmm not sure about that, however I do like the idea of the widget area. I am torn a bit as to what would be best.

Not increasing the width of the menu just to fit widgets in; we're pushed for space on some screens/themes as it is.

I've tweaked the widget area's font size down a bit (most themes seem to override the font size for the headings, but it helps with the body text in this narrow space), and figured a way to make most widgets kind-of fit. The calendar widget is one exception, but text continues to flow around it, and people can adjust the calendar widget's paddings if they must have it.

I suspect this area will be useful if the page template doesn't have a vertical sidebar, but at least it gives some options.

Not the most perfectly styled part of TS, but probably good enough.