paulirish/speedline

GraphicsMagick or ImageMagick?

Closed this issue · 4 comments

The readme says IM must be installed, but the module depends on the GM module.

I'm just confused on this. Is there a fallback layer in between?

@samccone and I looked at this a little closer. We're generally very happy with the source, though have a few questions.

We have an interest in using speedline inside of https://github.com/GoogleChrome/lighthouse/ which is browserified for one of our deployments. Is there a hard dependency on image/graphicsmagick for this buffer? We'd love if speedline was easily browserifyable.

cc @samthor

I wasn't planning to use ImageMagick at the beginning, but I was facing issues when extracting the screenshots from timeline. The get-pixel module is not able to parse the PNG. That's why I introduce an extra step where I use ImageMagick to convert each png in jpg before reloading them in memory. I faced the same issue for snapline.

By the way great job for lighthouse, I am looking closely at the project since it's early days. 😉

Seems like this module might be able to do what you want 💃
https://www.npmjs.com/package/pngjs2

I have a fix. Even easier.

PR incoming