paulirish/speedline

Drop bluebird for native Promises?

Closed this issue · 4 comments

samccone commented

You are using bluebird for .map but this should be pretty trivial to write with native promises, would you be open to this? 🍝 💀

cc @paulirish

image

pmdartus commented

@samccone sounds goods. I am more than happy to get rid of this dependency. 😄

I am using it especially for Promise.props. https://github.com/pmdartus/speedline/blob/17d37efa18adffec82917239681a5d995137c77d/src/speed-index.js#L12

samccone commented

Great, more than willing to open a PR to do this for you... feel free to assign me to this ticket.

👏

paulirish commented

These two are basic polyfills, and do not have any of their own deps:

https://www.npmjs.com/package/promise-props
https://www.npmjs.com/package/promise.map

samccone commented

we can just roll our own here, no need for any deps really.