paulknysh/blackbox

Python typing support

Closed this issue · 4 comments

Thanks for a great piece of code! Have you considered typing it?
That would make it easier to use and to improve on :)

Hi, what do you mean by "typing it"?

I mean adding type hints. The most amazing part about this repo is that it's simple enough to easily extend as needed. As an outsider, it would be much easier to extend the code if e.g. all the function parameters had type hints.

Moreover, it would make the code easier to use as static type checkers like mypy and pyright would pick up passing the wrong inputs to search_min.

Thanks, I've never tried these, would be interesting to potentially add at some point.

Added in #28