Homepage not saving acceptance
King-Nerd opened this issue · 5 comments
Hey Pauloo, love the homepage, but it seems you updated it recently and now, every time I try to open a new tab, it pulls your popup up asking about theme and settings, even after I have accepted multiple times. I don't know if my browser makes a difference, but I use the Brave Browser (built on Chromium).
Hello, how are you running it? Some kinda of self host or using the GitHub version (https://pauloo27.github.io/homepage)?
I am just using the Github version
EDIT: nvm, got it.
1) How often it happens? I also use Brave and I think it only happened to me once or twice.
2) Can you describe how you reproduce it? How do you open the homepage? Is it your new tab?
3) Also, can you open the Dev Tools console in the homepage (Ctrl + F12) and run localStorage.getItem("version")? It should return '2.4.0'
4) Since when you noticed the problem?
5) What Brave version are you in?
TL;DR: It's a issue with Brave (brave/brave-browser#17859)
After a few hours testing, I got the same problem.
The thing is that homepage looks in the localStorage for the version item, if it doesn't find it, it shows the welcome popup.
With some debug I've found that only "half" the localStorage is loaded when the check is made, and the version is not included in the loaded half resulting in a corrupt state.
I guess we have to wait.
Oh interesting. Well, I hope it get sorted out by them soon, I really enjoy using your homepage, but that constant pop-up definitely takes away from the fluidity of just typing right away. I will be patient and hope for the best!