pavel-odintsov/fastnetmon

fastnetmon_api_client unban / get_banlist: after unban IP is never -permanently- removed from the banlist

tyler0891 opened this issue · 2 comments

OS: Debian 11.1
Capture engine: AF_PACKET
Version: 1.2.4 master git-d32dc372591d795ede7e6c42045cda62d96b95af

Problem:
To troubleshoot BGP blackhole functionality after an update, I typically try to manually ban / unban an IP. With the version tested, when a -manually- banned client is unbanned (using fastnetmon_api_client) it is never -permanently- removed from the banlist, but is removed from GoBGP advertisements.

To duplicate:
fastnetmon_api_client ban {IP}
fastnetmon_api_client unban {IP}
fastnetmon_api_client get_banlist {IP}

Output in fastnetmon.log
fastnetmon.log

Was it only for IPv4 or IPv6 too?

We've reworked this logic completely 4a052e9 and it should not happen again.