Cannot compile TZDB.pas in Android and iOS platform due to usage of unit contnrs

Question

Cannot compile TZDB.pas in Android and iOS platform due to usage of unit contnrs

ccy opened this issue 6 years ago · 7 comments

tzdb cannot compile in Android and iOS platform due to the usage of unit contnrs. I think TBucketList may be replaced by TDictionary.

Answer 1 · 2018-06-27T09:04:46.000Z

Thanks for your bug report. @mbtaylor1982 you mind giving it a look? I've got not Delphi license.

Answer 2 · 2018-06-27T09:11:37.000Z

@ccy, As far as I remember, the TBitBucket was used due to it being shared across Delphi and FPC. TDictionary was not compatible at the time. I am not sure now what is going on,

Answer 3 · 2018-06-27T10:39:08.000Z

Your code base was designed to work for both Delphi and FPC. FPC might not have TDictionary.

Answer 4 · 2018-06-27T22:42:23.000Z

I’m busy moving house and with work commitments right now but as soon as I’m free I’ll take a look.

Answer 5 · 2018-06-28T02:16:42.000Z

I have done the fix: #6

Answer 6 · 2018-06-28T06:22:15.000Z

Thanks @mbtaylor1982, no worries about it. @ccy, I'll give it a look.

Answer 7 · 2018-08-14T13:13:34.000Z

Merged the PR