nextCloud Version 20 update?
BloodyIron opened this issue · 22 comments
Hey so any word on when this will have full compatibility with nextCloud 20? Really loving this app and literally broadcasting upgrading to nextCloud 20 as I type this lol. Thanks!
+ my vote
+1
The only issue I have seen so far is that opening drawio xml files from the "recommended files" dashboard doesn't open the file.
Using Firefox or Chrome I get a blank page when opening a drawing file. The console has the error:
Content Security Policy: The page’s settings blocked the loading of a resource at https://{domain}/ (“frame-src”).
Looks like the app needs to update the CSP header for Nextcloud (or the API for doing so has changed).
Note that I'm using a self-hosted draw.io server on a different sub-domain (e.g. Nextcloud is at https://cloud.{domain} and Draw.io is at https://draw.{domain}). Worked fine on NC 19.
php occ app:check-code drawio
gives a lot of errors, so NC20 support here needed as well.
- 150 ;)
+1
+1 on this from me. The issue i currently have with the plugin is that i cannot make a new xml file on the web interface. The page just loads for ever. But if i make an xml diagram from my desktop and put it on nextcloud the editor opens normally. So an update is needed. This app has been incredibly useful for our lab.
php occ app:check-code drawio
gives a lot of errors, so NC20 support here needed as well.
I just created a PR to fix these errors. I'll also try to fix any remaining problems for NC20 as needed.
Edit:
After checking my fork I also increased the version number and set the compatibility information to "up version 20".
On my Nextcloud 20 server it runs without any issues - ".xml" and ".drawio" work both without any issues (the latter one of course after updating the MIME type configuration in Nextcloud as documented). I also tested to create a new file within Nextcloud - no problem at all. There are also no CSP errors. I did this with a fresh installation of NC 20.0.2 to check this.
I recommend merging my PR and publishing an update for Nextcloud. If anyone needs a ZIP file to update the application manually before there is a new official release, just let me know.
Another thing I noticed: It seems the app aims to be compatible to Nextcloud as well as to Owncloud. Eventhough I understand the motivation - you should keep different branches for Nextcloud and Owncloud. It is not possible any longer to build apps which run on both platforms without any platform specific code.
Edit 2:
Also setting minimum supported version to anything lower than NC15 or NC16 makes no sense. Also see https://docs.nextcloud.com/server/20/admin_manual/release_schedule.html and the older schedule at https://docs.nextcloud.com/server/16/admin_manual/release_schedule.html - Nextcloud 15 was released nearly two years ago and is already end of life since 2019-12. Running such old versions is a security risk and people should be encouraged to user newer versions.
If anyone needs a ZIP file to update the application manually before there is a new official release, just let me know.
I guess a zip file could be helpful for a lot of us. With PRs (from early this year) still being open, it could take a while since your PR is merged.
And thank you so much for your efforts! Only the Drawio app was holding me back from updating to NC20.
You can find the ZIP file here: https://nextcloud.0x0c.de/s/w2KW4AZRBeR4585
@arnowelzel Thank you very much for this update. It work's very well in Chrome and Safari. But in Brave Browser I get the following error:
Can you please try it with Brave Browser and tell me if you have the same problem?
Edit: JavaScript is enabled and everything else in my Nextcloud works well.
Can you please check first, if https://app.diagrams.net/ works for you in Brave Browser?
Can you please check first, if https://app.diagrams.net/ works for you in Brave Browser?
Yes, it works without any problems :)
Edit: I also cleared browser cache and cloudflare cache after installing your version of the draw.io app.
Is this working for you?
When I click on the drawio file the Preview Window appears (instead of opening the file in draw.io):
This is the reason why I haven't updated and released the App yet. I didn't have time to dig into this.
But, since people seems to be "impatient" (can't blame them, though) I'm gonna release this version we got right now with "Known Issues" note.
I just checked it with Brave Browser Version 1.17.73 (64 bit version running in Windows 10 Pro).
So far I could not find any issues - Draw.io works fine here:
I also can not confirm the XML problem. Did you forget to enable the option "Associate XML files with Draw.io?" in the additional settings in Nextcloud?
In addition: If anyone needs a test account on my Nexcloud development server (which runs the latest stable version of Nextcloud) for reference, send me an e-mail.
I just checked it with Brave Browser Version 1.17.73 (64 bit version running in Windows 10 Pro).
So far I could not find any issues - Draw.io works fine here:
I also can not confirm the XML problem. Did you forget to enable the option "Associate XML files with Draw.io?" in the additional settings in Nextcloud?
Thank you for looking into this, Arno. I figured out that I have to disable the tracking protection for my Nextcloud by clicking on the Brave Logo on the right side of the search bar :)
@mariusbolik thanks for the feedback
About the XML issue - I did not realize, that this was about opening an XML file from the Dashboard app. When using the ".drawio" extension this does not happen. In this case, the file browser is opened and the file is selected there.
This may be a bug of the "Dashboard" app which should be reported there as well.
@pawelrojek The problem is the "recommendations" app. This app is responsible for the "Recommended files" box in the dashboard as well as the "recommendations" on top of the Nextcloud file manager. It seems this app just ignores MIME types - neither XML nor .drawio works as expected.
I created a new issue for this: nextcloud/recommendations#340
However, we should release Draw.io anyway - whatever this problem is, we should not wait with the update, since everything else works just fine.
@arnowelzel
I agree. It's on the App Store now.
Can confirm that the "new diagram" issue is fixed with the latest update.