paypal/squbs

The vararg methods in RequestContext should require one argument.

crankydillo opened this issue · 1 comments

def withResponseHeaders(headers: jm.HttpHeader*): RequestContext =

Basically, this shouldn't compile:

requestContext.withResponseHeaders()

I tried to quickly address this, but the deprecation is a tad tricky:P

I spoke with some people, and two valid issues were raised. First, having a required argument will make this weird to use with list->vararg expansion. Second, there are some performance implications regarding Map/List creation + appends.