Improper class casting can happen in RequestContext
crankydillo opened this issue · 3 comments
crankydillo commented
This cast can fail. It is worrisome because a client would normally expect the Failure to be some kind of HTTP thing.
AFAIK, AKKA only has the Scala implementation for the Java-based abstract HttpResponse
, but we should still address this if the cost isn't too high.
anilgursel commented
Not worried about the casting to be failed (as there is one implementation), but I agree it looks unnecessary (at least without looking into details). We should instead keep the API with jm.HttpResponse
.
jfiske01 commented
I never signed up for this email people. How do I get out of this forum?
…On Mon, May 14, 2018, 3:39 PM Anil Gursel ***@***.***> wrote:
Not worried about the casting to be failed (as there is one
implementation), but I agree it looks unnecessary (at least without looking
into details). We should instead keep the API with jm.HttpResponse.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#654 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AjzPM2x-59wrgP_IRz3dXZlIl7OZx0VDks5tyfmigaJpZM4T6nnX>
.
anilgursel commented
Just click on "Unwatch" button at the top.