Concurency safe validators?

Question

Concurency safe validators?

buni opened this issue 2 years ago · 11 comments

I've a use case where concurrency safety is needed (a middleware), and I noticed that validator instances are not concurrency safe. I wasn't sure if it was by design?
I think the library would be more useful if validators were concurrency safe. I'm happy to do the work myself if outside contributions are accepted.

Answer 1 · 2023-09-18T12:38:02.000Z

Would you mind showing me the issue / error you see when running the validator as middleware? There should be no mutations, only internal state changes.

The goal is to be concurrency safe, any help you can provide to show me where the library gets upset and I can fix it.

Answer 2 · 2023-09-18T15:53:42.000Z

I've a couple of basic test cases for the race conditions I found https://go.dev/play/p/Y1CUxCwOjPG
In addition all SetPathItem methods are not concurrency safe.

Answer 3 · 2023-09-18T22:01:35.000Z

Can you try v0.0.20 and see how you get on? This addresses some other concurrency issues reported in the stack.

Answer 4 · 2023-09-20T14:26:07.000Z

I'm still getting race conditions when running my test cases.

Answer 5 · 2023-09-20T16:29:33.000Z

This branch should have all data races that I found fixed, there might be more since my tests were very basic. Feel free to use that code as a pointer, I quickly threw it together when I was initially testing your library so its no the pretties. Also you might want to run a linter, golangci-lint found some potential issues when I ran it on the project.

Answer 6 · 2023-09-21T10:13:35.000Z

Thank you, I will circle back on this ASAP and do another concurrency cleanup.

Answer 7 · 2023-12-21T17:00:00.000Z

Hey @daveshanley , any news on this ? Got concurrency problems in my tests on version 0.0.37:

fatal error: concurrent map writes

goroutine 337 [running]:
github.com/pb33f/libopenapi-validator/requests.(*requestBodyValidator).ValidateRequestBody(0x14000033440, 0x140002b0500)
	/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.37/requests/validate_body.go:80 +0x404
github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpRequest.func2(0x0?, 0x0?)
	/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.37/validator.go:247 +0x3c
created by github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpRequest in goroutine 436
	/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.37/validator.go:267 +0x2f0

Answer 8 · 2023-12-22T18:40:48.000Z

This is a new one. I think it can be solved pretty easily.

Answer 9 · 2023-12-22T18:52:22.000Z

@Sakdow can you try v0.0.38

Answer 10 · 2024-01-05T21:16:16.000Z

Sorry for the late reply. It's working perfectly now, thank you!

Answer 11 · 2024-01-18T20:27:32.000Z

I can't detect any race conditions in tests or in production use. Until this comes back around, closing for now.