pbrisbin/wat

Wat no longer working

Closed this issue · 8 comments

orschiro commented

Hi @pbrisbin,

Just discovered that wat is no longer working:

~ ❯ wat
1 starting full system upgrade

This is all I get. Does it have to do with the recent upgrade of pacman 4.2?

Thanks!

Robert

pbrisbin commented

Hi thanks for the report. It's almost definitely due to the update in pacman, since wat is directly tied to the format of the lines in the log, which I'm sure they don't worry about for backwards compatibility.

If you're interested in contributing, you could take the following steps:

  • Update test/pacman.log to whatever the new format is
  • Confirm the tests now fail
  • Update here and maybe here and here to make the tests pass
  • Open a PR with your fixes

If not, I'll take a look at this some time this week.

orschiro commented

If not, I'll take a look at this some time this week.

Thanks for the guidance. I will try my best! :)

jnwatts commented

I just upgraded to the new pacman, there doesn't seem to be an appreciable change to the log. I have (in my ~1 day of experience with wat) seen the above printed out at various points. If you perform a system upgrade and there are no results, then wat (correctly) shows an empty set of changes.

I think the only change to the log file is the label of "installed" events, which is now [ALPM] instead of [PACMAN]. This shouldn't matter to wat, as the regex only looks at the message and not the label.

orschiro commented

If you perform a system upgrade and there are no results, then wat (correctly) shows an empty set of changes.

Hey, you are totally right! Now, I also performed an actual upgrade and the output is as desired:

❯ pkgLog
1 starting full system upgrade
upgraded cmake (3.1.0-2 -> 3.1.1-1)
upgraded nodejs (0.10.35-4 -> 0.10.35-5)
upgraded wine (1.7.34-1 -> 1.7.35-1)
upgraded altyo-git (0.4_rc12.1.r17.g131e481-1 -> 0.4_rc12.1.r18.g3f6b508-1)
upgraded mesa (10.4.2-1 -> 10.4.3-1)
upgraded lib32-mesa (10.4.2-1 -> 10.4.3-1)
upgraded lib32-mesa-libgl (10.4.2-1 -> 10.4.3-1)
upgraded libmm-glib (1.2.0-5 -> 1.4.2-1)
upgraded libnm-glib (0.9.10.0-4 -> 1.0.0-1)
upgraded mesa-libgl (10.4.2-1 -> 10.4.3-1)
upgraded mesa-vdpau (10.4.2-1 -> 10.4.3-1)
upgraded openresolv (3.5.7-2 -> 3.6.1-1)
upgraded wat-git (r4.16caa72-1 -> r5.3cb8588-1)
upgraded numix-icon-theme-square (1:0.r79.bb074b2-1 -> 1:0.r81.e4612a6-1)
upgraded translate-shell (0.8.22.5-1 -> 0.8.22.5-2)
upgraded pulseaudio-ctl (1.59-1 -> 1.59-2)
upgraded lostfiles (3.11-1 -> 3.11-2)
upgraded copyq (2.4.3-1 -> 2.4.4-1)

So indeed, I think nothing needs to be changed here. :)

Sorry for bothering,

Robert

orschiro commented

Finally I realised where the culprit was: pacaur.

I use it to update my AUR packages. Thus I was wondering why wat did not show the packages that I updated via pacaur. Is it possible to extent wat to the packages installed by managers other than pacman?

pbrisbin commented

I was wondering why wat did not show the packages that I updated via pacaur.

Because they most likely invoke pacman -U x which generates only an installed x style line in the log (not upgraded x).

Is it possible to extent wat to the packages installed by managers other than pacman?

Yes and no. The solution would be show also any installed x lines between upgrades. In fact, there's an open PR (#2) to do just that.

At this time, I don't think I want to add that. wat is about showing what was upgraded. Expanding the output to include anything installed is not in line with that goal and only incidentally makes aur-upgrades appear in the output. I'm still thinking about it though.

pbrisbin commented

Closing this. Feel free to plead your case in #2 if you feel strongly.

jnwatts commented

Interesting viewpoint. I didn't realize installed vs upgraded was so
important to you (my need of the tool when I found it was the inverse: wat
dafuq did I install?).

I can update #2 to be optional (wat -i?)
On Jan 26, 2015 10:37 AM, "pat brisbin" notifications@github.com wrote:

I was wondering why wat did not show the packages that I updated via
pacaur.

Because they most likely invoke pacman -U x which generates only an installed
x style line in the log (not upgraded x).

Is it possible to extent wat to the packages installed by managers other
than pacman?

Yes and no. The solution would be show also any installed x lines between
upgrades. In fact, there's an open PR (#2
#2) to do just that.

At this time, I don't think I want to add that. wat is about showing what
was upgraded. Expanding the output to include anything installed is not in
line with that goal and only incidentally makes aur-upgrades appear in the
output. I'm still thinking about it though.

—
Reply to this email directly or view it on GitHub
#1 (comment).