pcah/python-clean-architecture

No clean arcitecture is implemented

Opened this issue · 0 comments

According to Uncle Bob, application and domain layers should implement business logic itself. Minimal magic and usage of frameworks is expected there. Gateway interface should be concrete and defined in terms of business logic (e.g. used by application layer) and located inside the layer which uses it. Gateway interfaces should follow ISP. DTOs should be simple structures without any logic

In current repo I see a lot of magic related to the layers which should not use it at all. Interfaces are unclear. DTO is inheriting from dict so it does not have any clear structure as well.

This repo looks contradicitng the Ideas of Clean Arctitecture.