pcawte/AgDev

Parameter order in vdp_cursor_tab does different from what header file suggests.

Closed this issue · 1 comments

In include/agon/vdp_vdu.h

void vdp_cursor_tab( int row, int col );

This implies first parameter is row, second parameter is column. AgDev 1.2.0 did implement the function that way, therefore consistent with the header file.

AgDev. 2.0.0 implements the parameter order reversed (first parameter is now column, second parameter is now row), but the header file has not changed. Breaking changes like this are never a good idea, especially when they are not documented. The header file must be consistent with the implementation..

The column, row order may be more consistent with the VDU command sequence (and BBC Basic TAB(x,y)), but please document it if this change was intentional. And keep it the same from now on!

I adjusted the declaration to match the implementation again. Thanks for reporting! #36