pcfens/puppet-filebeat

close_timeout should be string not integer

ehontoria opened this issue · 0 comments

Based on the documentation for the close_timeout parameter for inputs: https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-log.html#filebeat-input-log-close-timeout

Right now that option can only be an integer, but the documentation states that options include 5m which indicates that this type should actually be a string so that users can set the duration between closing.

Essentially the fix is to set https://github.com/pcfens/puppet-filebeat/blob/master/manifests/input.pp#L40 to be String instead of Integer and perhaps add some validation on the input values if really necessary.