pcwii/kodi-skill

Could you elaborate on line 111?

Closed this issue · 0 comments

Why do you set the kodi_ip, kodi_port, etc after checking that it has valid entries?
I don't really get it.

def on_websettings_changed(self):  # called when updating mycroft home page
        if not self._is_setup:
            kodi_ip = self.settings.get("kodi_ip", "127.0.0.1")
            kodi_port = self.settings.get("kodi_port", "8080")
            kodi_user = self.settings.get("kodi_user", "")
            kodi_pass = self.settings.get("kodi_pass", "")
            try:
                if kodi_ip and kodi_port:
                    kodi_ip = self.settings["kodi_ip"  ]
                    kodi_port = self.settings["kodi_port"]
                    kodi_user = self.settings["kodi_user"]
                    kodi_pass = self.settings["kodi_pass"]