Elm has a nice logo but it needn't dictate syntax highlighting
frou opened this issue · 9 comments
Hi there - Thank you for providing this nice documentation. You know the green colour that's used in the docset for the colons and arrows in type signatures?
Its RGB value seems to have been picked directly off the Elm logo (the tangram thing), which is cute, but for actual use, that bright green colour is not very readable against a bright white background!
How about toning it down to an unassuming #aaa or something? I think it's set here in the CSS.
cc @kraklin
That’s probably a good idea. Let me try it out, I’m not sure how would it end up looking
@frou - I have tried to change it a little bit, but I don't know... I have used the green colour that is right now used at package.elm-lang.com which is darker and for those types delimiter I have used 808080 - I kind of miss how the types stand out with the brighter green that is used right now to be honest. WDYT?
current one:
new one:
I think that new style is great. In general if we consider what makes something visually stand out, it is not only colour, but shape too. Things like colons and arrows inherently stand out because their glyphs are interesting shapes.
I imagine people downloading the docset expect it to look like the official docs, just inside Dash. So moving in that direction is unlikely to outrage anyone!
Yes, but I think I'll try to make those arrow delimiters a little bit more subtle though :D
@frou ok, you asked for it - syntax highlighting uses the same colours as on package.elm-lang.com as well:
^^ this is actual output of elm-docset, not screen from package.elm-lang.com :D
Brilliant. This is a good stuff!
Ok, I’ll try to deploy it with next update
@frou it is there waiting to be merged in this pull request
https://github.com/Kapeli/Dash-User-Contributions/pull/2655/files
Thanks man, I appreciate it