peace-maker/smrpg

Regen does not accept float values for heal increase

Closed this issue · 5 comments

As the title states the
`// Additional HP to regenerate each interval multiplied by level. (base + inc * (level-1))

// Default: "1"
// Minimum: "0.000000"
smrpg_regen_amount_inc "0.1"
`

does not accept values lower than 1

How do you envision this to work? Health is an integer, so setting the increment to 0.1 would truncate to 0 until level 10?

I wouldn't set it this low. I was just playing around with the values, but yes basically I want for one level to be less than 1 hp since there is also the interval that can be changed in the config. I want to have many levels (40+) for the skill but not have the player receive 40+ hp per second.

EDIT: It could also work like the following:
A player has upgrade level 3 with values set at base regen 1 and increment 0.5 per 5 seconds.
So he would regenerate 2 health every 10 seconds and 1 every 5 seconds. However I think this might take some extra storage for the health that is only added every 10 seconds.

It is in the documentation aswell


// Specify the base amount of HP which is regenerated at the first level.
// -
// Default: "1"
// Minimum: "0.100000"

The minimum value is a float. So it would seem you intended it to work this way.

Did you implement this yourself? Pull requests are very welcome!

Yes, Id love to make a pull request, but wasn't able to create a branch for your repository. I made a copy of it on my account and pushed the changes there. I invited you to check it out. Sorry if I got something wrong, this is the first time I am using this.

EDIT: Nvm I made a pull request. :)