peerchemist/finta

ZLEMA not using any EMA

Closed this issue · 1 comments

The ZLEMA function seems to only return the transformed data (before handling it to the ema method) but doesn't actually perform the EMA on the data.

The method code is:

       lag = (period - 1) / 2
        return pd.Series(
            (ohlc["close"] + (ohlc["close"].diff(lag))),
            name="{0} period ZLEMA.".format(period),
        )

Which doesn't include any EMA i.e. it is missing the last step in the ZLEMA pseudocode: https://en.wikipedia.org/wiki/Zero_lag_exponential_moving_average

You are right, resolved with eabc47e