Remove createJSModules from packages of Android templates

Question

Remove createJSModules from packages of Android templates

peggyrayzis opened this issue 7 years ago · 2 comments

This was a breaking change in RN v0.47.2. Not sure if overriding this method is necessary for native modules to work in earlier versions -- if so, we'll need to check the version in package.json and update the templates accordingly.

Answer 1 · 2017-08-29T17:44:09.000Z

And the compiler fails if that method isn't overridden in earlier versions :( looks like we have to do the version check

Answer 2 · 2017-08-29T19:06:58.000Z

Had the same issue with react-native-orientation. It's a breaking change for Android. Anything above v0.47 needs to have it removed, otherwise it breaks compilation. Any project before v0.47 definitely needs the @Override call.