random crash in rocky while zooming and panning
keince opened this issue · 12 comments
While running rocky, I'm noticing a random crash while panning around on the Earth (see attached image below on details).
I'm seeing this running the rdemo.exe and rengine.exe apps. It appears to happen at different times during execution but it happens regularly at the same location in the code (vsg).
My environment...
OS: Windows 10
IDE: Visual Studio 2022
Configuration: RelWithDebInfo
Platform: x64
Just a follow-up to my previous post,..
I'm noticing that the process memory (in the diagnostic tools) steadily increases as I move around until it reaches 10.1+ Gb. It is at this point that the crash occurs.
As an experiment, I changed the resourceHints->numDescriptorSets on line 193 and the value on line 195 in rengine.cpp from 1024 to 2048. It pushed off the crash until the process memory reached ~14.5 Gb and then it crashed.
It's like paging memory isn't being released somewhere...
Yes. I have noticed the same thing, and it seems to be a function of the pre-allocation of pools in ResourceHints.
In rengine.cpp we are using those resource hints and there's a big memory leak. In rdemo (the code is actually in Application.cpp line ~564) however we're limiting the numDescriptorSets to 1, and there problem doesn't exist.
I am not smart enough about the guts of VSG (yet?) to know what's up, so I appreciate the experimentation and sharing of knowledge :)
Thanks for the feedback Glenn.
For the record, the crash still occurs with rdemo.exe like the other applications.
Looking at my version, it has resourceHints->numDescriptorSets = 64; for line 564.
I will do some further research and investigation on the matter on my end to try and help...
Grab the latest (with numDescriptorSets = 1) and let me know if you still se the problem.
Okay.
I did a pull of the rocky repo.
Do I need to rerun the bootstrap-vcpkg.bat file to update?
Probably not, but I would definitely re-run cmake on your build folder.
I was finally able to run the rsimple.exe application with the aforementioned changes to the numDescriptorSets and the crash has not happened yet.
However, now I'm seeing something different. It appears that paging stalls periodically so that the higher LODs don't page in.
I've attached a picture showing the problem.
Can you give me the viewpoint?
In rdemo, open Camera->Viewpoints and take a screenshot.
Here's a capture around the same area with viewpoint displayed. It might be the source imagery for the tile but I don't see this in osgEarth using ReadyMap...
It's just missing data on the server. (This is osgEarth, Rocky, and ReadyMap console from left to right)
As for rengine, I pushed a quick fix for that -- I would stick to rdemo for the most part since that's the app that gets the most attention. I do not spend as much time keeping the other 2 up to date :)