`basic.fit()` should also return baseline intensities

Question

Closed this issue 2 years ago · 5 comments

Considering basic.fit() also does the baseline fitting, the estimated baseline (for photobreaching etc...) should be returned.
example:

basic=Basic()
basic.fit(train_images)
corrected, baselines = basic.predict(test_images)
# corrected, baselines = basic.fit_predict(train_images)

Answer 1 · 2022-01-17T23:58:41.000Z

merged to the broader issue and close.

Answer 2 · 2022-01-20T02:01:37.000Z

Reopen as the current version returns corrected images only.

Answer 3 · 2022-01-20T16:37:53.000Z

Yes, my first pass at predict was only to implement something straightforward. Baby steps and incremental change are easiest :)

I meant to re-open this and forgot.

Answer 4 · 2022-07-01T14:02:51.000Z

An array of baseline values are included as a parameter of the BaSiC class (basic.baseline) so we do not need to return baseline with transform.

Can we close this issue? @yfukai @Nicholas-Schaub

Answer 5 · 2022-07-03T06:16:42.000Z

Yeah let's close this.