penge/block-site

can't block this website

olfek opened this issue ยท 8 comments

olfek commented

I can't block

geforcenow.com
olfek commented

not much that can be done about this because in

https://developer.chrome.com/docs/extensions/reference/tabs/#event-onUpdated

changeInfo.url

is always the resolved (after redirection in this case) URL

penge commented

I think we could read the URL before redirecting using:
https://developer.chrome.com/docs/extensions/reference/webNavigation/#event-onBeforeNavigate
(requires new permission webNavigation)

For now, I would try to block:

nvidia.com/en-eu/geforce-now

Is that sufficient?

olfek commented

yeah that's fine for now

olfek commented

why has it been closed? it is still a bug that needs fixing.

penge commented

Sorry, I thought blocking redirected destination is good enough. (also because I'd prefer not adding that new permission)
I'll open it and try to solve it.

olfek commented

thanks ๐Ÿ™‚

penge commented

@olfek
Just to let you know, this feature has been now implemented and you can expect it to be released starting next week.

block-before-redirect

olfek commented

@penge thank you so much! ๐ŸŽ‰๐ŸŽ‰๐Ÿ™‚