penge/block-site

Bug - Extension icon not visible in incognito mode

olfek opened this issue ยท 6 comments

olfek commented

image

penge commented

Very subtle indeed. The only way is to either change icon color so it's ok in both normal and incognito, or give the icon a white background but that would make it look worse in normal mode ๐Ÿ’

Looked up https://developer.chrome.com/docs/extensions/reference/extension/#property-inIncognitoContext with https://developer.chrome.com/docs/extensions/reference/action/#method-setIcon but it's not a method that would work here (as there's no way to set icon from background script before the extension is started in incognito).

How about an icon, where the "B" has a small white border. This way it will work in all the cases.

penge commented

@olfek and @anshulxyz

What do you think about this new icon?

Icon

light



Toolbar

light

dark



Options

block-site-options



The idea is to have icon that would look also good in Dark Mode or Incognito Mode, as pointed out by @olfek. Because the new icon would no longer be a simple black bold B, it is also shown in Options page, to make a clear connection between the toolbar icon and Options page.

Note: To make it a bit easier to visit the Options, a simple left mouse click on the icon will work now. Before: Right click on the icon, then click on Options from the menu. This option will still be there as it's standard behavior.

olfek commented

its perfect @penge

penge commented

@olfek Great! I'll be adding it to the next version then. Shoud be out in about 2 days.

@penge looks great, good visibility