penibelst/jekyll-compress-html

Paragraph ending tag </p> is removed inappropriate

Closed this issue · 5 comments

laukstein commented

Here HTML having layout: compress:

<p>Text</p>
<a href>Link</a>

it is wrongly converted to

<p>Text <a href>Link</a>

that browser will understand as

<p>Text <a href>Link</a></p>

The expected result here is

<p>Text</p><a href>Link</a>

</p> is one of the optional ending tags (could be dropped and stil have valid HTML). But when dropped in inappropriate place, it can break the whole layout. The same for </li>, </ol>, etc.

jnvsor commented

I see. I'll remove it from the default ending tags list tonight. Thanks!

jnvsor commented

@laukstein Actually now I'm wondering whether I should again, there are a lot of other elements that could go wrong in the same way...

jnvsor commented

Looks like most of the ending tags are inside containers of some sort that do require ending tags (<table>, <ul>, etc) so fixed in 00a5b73

laukstein commented

@jnvsor, perhaps _layouts/compress.html needs to be updated too? Can you update it?

jnvsor commented

Well that was stupid. I forgot I have to manually upload the built file to the tag when it's done. Now available for download on the tag page