pep8speaks-org/pep8speaks

Handle payloads with large number of files changed

OrkoHunter opened this issue · 3 comments

OrkoHunter commented

Related issue: #178

In PR where 100s of files are changed, there is a possibility the request will timeout. Since, the bot makes a comment, the GitHub Payload can be responded immediately. The lint job and commenting on PR can be done asynchronously.

grapheo12 commented

Should this be tackled with a full fledged task queue? Or by just using an async function?
I can come up with a PR if you want.

OrkoHunter commented

Hey Shubham! Thank you for the interest! Even if task queue seems like a good way to go, it might be overkill here. An async function should be sufficient for most of the cases. I can not think of a drawback.

  • 👍1
Mr-Sunglasses commented

@tushar5526 We might work on making pep8speaks async, I can be a major rework, Also thinking of using fastapi as an ASGI.