Support SGP30 over I2C
Closed this issue · 1 comments
0x46616c6b commented
What kind of new feature are you looking for?
- Hardware: SGP30
I implemented in this repository the SGP30 already and want to ask if I can contribute this piece of code. It is fully functional but I did not implemented the CRC checks which are mentioned in the datasheet.
Do you plan to:
- Contribute an initial driver: Yes
- Write unit tests: No
- Update https://github.com/periph/cmd to use the new functionality: Yes
maruel commented
It looks great! The only nit would be to not export the commands. Thanks!