perl-net-saml2/perl-Net-SAML2

Check return code for verify_xml

timlegge opened this issue · 1 comments

timlegge commented

perl-Net-SAML2/lib/Net/SAML2/Binding/POST.pm

Line 65 in 9d9ac1a

$self->verify_xml(

verify_xml only returns 1 and croaks if an error occurs in any verification but it is likely a good idea to check that it returns 1 in case someone adds a return somewhere by mistake.

waterkip commented

verify_xml should croak on failure and not emit other type of return codes tbh. We could also change it to just return.