perseids-publications/treebank-template

could we make morph retrieval an optional parameter?

Closed this issue · 2 comments

For purposes of publication of trees, there isn't really any value in doing the retrieval from the morphology service, and it just adds alot of unnecessary service calls.

It can be disabled by setting noRetrieval: "online" in the morph plugin configuration. Could we make it possible for the treebank-template to have this set it its config.json file (and thus carried over to ArethusaConfig.js) so that users of the template can decide whether they want it or not? (I don't really know if there is ever a reason it would be desirable but don't know if we want to rule that out).

That's a great idea. Combined with alpheios-project/arethusa#803 and #9 it would mean that the Treebank Template is entirely self contained.

I think that we can just do the simplest thing and add noRetrieval: "online" to the config. If there is someone who needs that functionality, we can always add the option later.

Addressed in #28