petabridge/NBench

TestRunner ignores the TestPackage.OutputTargets list

taaaki opened this issue · 0 comments

When working with a TestPackage, it is possible to add a custom IBenchmarkOutput implementation using the TestPackage.AddOutput function. However, any such custom IBenchmarkOutput implementations are effectively ignored by the TestRunner as it does not include the TestPackage.OutputTargets when constructing the CompositeBenchmarkOutput that is then used by the runner. Based on the summary comment for OutputTargets, this appears to be an accidental omission rather than a design choice.

There is a workaround whereby the TestRunner can be inherited from and the CreateOutput function overridden to produce the CompositeBenchmarkOutput that includes the additional output targets. But this doesn't appear to be the intended approach as far as I can tell.