petdance/file-next

Race condition causes test failure under parallel testing

Closed this issue · 8 comments

http://www.cpantesters.org/cpan/report/61a8fe24-4936-11e3-b097-b376ba4edfeb

Easiest way to replicate this:

$ perl Makefile.PL
$ make
$ prove -bvrj2 t/everything.t t/follow.t

Essentially the flaw is multiple tests augment the same directory simultaneously, and then get confused by each others changes.

Though I don't think this is the only combination that causes a failure, just its the easiest to find.

This is still a problem.

Each test needs to use its own tempdir, rather than the same one for all tests. File::Temp can help (and it's in core).

I got this again while installing everything fresh for 5.20.0.

See #17 for a specific test we know needs to use a temp dir.

Anybody have a patch for this handy?

Fixed with 0f2d2dc and releasing in 1.13_02.

Awesome, thank you!

Looks like you did your batch of darwin tests at http://matrix.cpantesters.org/?dist=File-Next, so I'm guessing you're OK with a release at this point.