petergridge/Irrigation-V5

Some bugs

zanna1972 opened this issue · 10 comments

Hi, I've installed and tested your integration and it's very interesting, but I have found some bugs.

For each zone I have configured the pump entity and it's ok... solenoid on and pump on... fantastic!
Then I decided to keep my pump always on, so I removed from each zone the pump entity, saved and applied.
I turn on the pump switch, but after few seconds it moves to off. I have disabled the program, but nothing was changed. I uninstalled your integration and now I can move mi pump on and it stays on.

I have a water well, sometimes It became empty and I must no acrivate the pump and irrigation.
I have a sensor in the water well to detect if it's empty, and I used this as "Rain sensor" to prevent start, but I read that "Rain sensor" Is not taken into consideration in manual-mode.
Could you add a new configuration option to manage the water well?

Could you check these bugs? And tell me if there is a workaround?
Many thanks, and congratulations, it's really a super useful integration.

Hi @zanna1972

I have moved V5.4.13 from beta to the current release this fixes part 1 of your issues.

Part 2 is a little more complex. I can add a water source monitoring option but cannot think of a suitable workaround for this
I will build this expecting a binary sensor:

  • When 'off' the program will not run
    From a service call,
    From a scheduled start or,
    From a manual start
  • When a program is running and the sensor changes to 'off'
    The program will terminate after a short delay

Let me know if this is what you want

Cheers
Pete

I am testing the changes now, there is a 5 second delay in turning the pump off in line with the delay for the flow meter processing. Hopefully this is not going to cause any issues with the pump running dry. I will hopefully release a beta by the end of the week. I typically leave the Beta for 3-4 weeks, in case there are any latent bugs that I did not find.

Hi, I have release 5.4.15 Beta that has water source monitoring, thanks for helping with testing

I prefer to have a consistent approach. Rain sensor on, it is raining. Water source on, there is water. Zone enabled, and so on.

Hi, You can create a template binary_sensor helper.

"{{ is_state(binary_sensor.well,'off') }}"