Wrong Check on Official LOVE AppImage
MikuAuahDark opened this issue · 4 comments
Lines 24 to 27 in 84af8c1
This won't catch LOVE 12.0, 12.1, 12.2, 12.3, 13.0, and so on.
Suggested change:
if (parsed_version[0], parsed_version[1]) >= (11, 4):
return download_official_appimage(version)
I don't know how you found that, but thank you for the early notice! I'll double check why it is that way and then fix it. I don't think it's worth it to release a new version for it. Would it be okay to give a day's notice before releasing love 12 or something?
A new commit is not necessarily a new release.
That was kind of my point. It's fixed on master now, but I don't think I want to release for this. I am pretty sure most people just install makelove via pip, so it should be updated there if people are supposed to use it. Do you think you could notify me a day before releasing love 12, so I can release then?
Ah. Yes sure thing.