pguyot/Einstein

Build fail: Two files mentioned in Linux Jamfile not in master branch

Closed this issue · 4 comments

toxicgumbo commented

Two files mentioned in Einstein/_Build_/Jam/Jamfile don't exist in the master branch. These can be found on lines 245-246:

COMMON_CPP_SOURCES      += "$(BASE)Emulator/JIT/Generic/TJITGenericRetarget.cp" ;
COMMON_CPP_SOURCES      += "$(BASE)Emulator/JIT/Generic/TJITGenericRetargetMap.cpp" ;

Commented out, the Einstein binary will build successfully in Ubuntu 18.04.3 minimal install, 32-bit, in VirtualBox 6.0.14 on Mac OS 10.15.1.

The build instructions I followed:

https://github.com/pguyot/Einstein/wiki/Build-Instructions

MatthiasWM commented

Please remove the reference to those files from the JamFile. They should not be needed any longer. Sorry about that.

toxicgumbo commented

Pull request issued for file reference removal. Review and approval requested.

chuma commented

@toxicgumbo is there a reason you didn't build Einstein using CMake?
Linux-(x86)-build-and-run-instructions

toxicgumbo commented

Fair question. Likely an oversight after having jumped back and forth between build docs amidst other responsibilities. This explains why I remembered it being less grumpy months ago :-)

I'll re-approach the preferred method (which you've linked to) in 32-bit minimal Ubuntu 18.04 (https://help.ubuntu.com/community/Installation/MinimalCD) and see if there was something that led me to go deprecated.

  • 👍1