New Feature: a `PharIo\Manifest\ManifestValidator` will be greatly appreciated
Opened this issue · 6 comments
Hello,
As title suggest new class, it will be greatly appreciated to have ability to validate a manifest after creation by API or loading from external source !
Any news about this new feature ?
I still like the idea but I'm not convinced it belongs into this project but should be a separate library.
What do you think?
Sorry but I don't think it should be separated from this project !
It's same thing, if you said :
- we should separate PHP DomDocument validation against schema from dom extension :
--> DOMDocument::schemaValidate - we should separate Composer validation against schema from its project :
--> https://github.com/composer/composer/blob/2.6.5/src/Composer/Command/ValidateCommand.php
--> https://github.com/composer/composer/blob/2.6.5/src/Composer/Util/ConfigValidator.php#L53
--> https://github.com/composer/composer/blob/2.6.5/res/composer-schema.json - or we should separate BOX validation against schema from its project :
--> https://github.com/box-project/box/blob/4.4.0/src/Json/Json.php#L91
--> https://github.com/box-project/box/blob/4.4.0/res/schema.json
I stop here list of examples that provided embedded validator features !
I know it's more work for you, but it'll help to improve QA of your project.
okay, point taken. I'll probably implement that over the next week when I'm traveling. Let's see how that works out :)
Any news about status of this new feature ?
I hope to have some time working on these soon.