pharmaverse/admiralvaccine

Scope of admiralvaccine (reactogenicity)

Closed this issue ยท 0 comments

bms63 commented

Everything is looking good! @federicobaratin and @YaminiBollu can you review this PR for @iaugu. I think this is the next step for you all, i.e. reviewing Pull Requests.

All checks are passed ..super good.. ๐Ÿ‘ just a minor thing i noticed when going through Rmd file. may be we can remove "vaccine" in the documentation part. As we have reactogenicity data in pharma as well and i feel like even they can adapt this template for their studies.. please comment.. adce_vignette

Good point @YaminiBollu ! I think since the scope of the package is for Vaccines, then we can leave as is for now. However, this brings up some past struggles admiralonco had with admiral, i.e. where should functions live to make it more accessible. I'll make an issue of this for later discussion

Originally posted by @bms63 in #109 (comment)