Update derive_param_diam_to_sev function
vikrams95 opened this issue · 0 comments
vikrams95 commented
Feature Idea
- The output of the function should not be assigned to a name, i.e.,
df <-
in line 216 should be removed. Otherwise the output is not displayed in the console and in the example on the website. - Arguments starting with "filter_" should expect filter conditions. Here they expect variable values. I would rename them to something like
diam_code
orfaobjj_values
. derive_param_*()
functions should create BDS parameters, i.e., at least PARAMCD should be set for the new records. If this is not intended, the function should be renamed to something likederive_severity_records()
.- Do you expect gaps for the severity? E.g.,
mild = c(2, 4), mod = c(5, 10)
? If not, you could simplify the arguments such that they expect the lower limit of the severity, i.e., the default would benone = 0, mild = 2, mod = 5, sev = 10
.
Relevant Input
No response
Relevant Output
No response
Reproducible Example/Pseudo Code
No response