pharmaverse/admiralvaccine

Update ADFACE template

Closed this issue · 1 comments

vikrams95 commented

Feature Idea

  1. Add missing codelist values in lookup dataset in derive_var_params step.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response

arjoon-r commented
  • I would use convert_blanks_to_na() around the datasets at lines 32-37. - just so users are aware of this functions existence as most folks are going to read in sas datasets. You can also write a comment on the purpose of this function - see other admiral templates for examples. Then remove all these calls in later lines of this template
  • I would remove admiraldev, readxl, metatools as no functions are used in the template from those packages that I can tell
  • I would update the Input on Line 5 with the supps as well
  • Is the keep_vars object necessary? I'm not noticing any change in lines 212 adface versus lines 233 adface