Peer review of - apply_cut.R, drop_temp_vars.R & process_cut.R
alanaharris22 opened this issue · 1 comments
alanaharris22 commented
Peer review of - apply_cut.R, drop_temp_vars.R & process_cut.R
alanaharris22 commented
FYI @reesnj - a few comments for you to consider (mainly documention related!)
General Comments:
- When referencing the other functions and code if you reference them in backticks (`) it'll add a hyperlink to the functions' page and also show the code in a different font.
drop_temp_vars.R:
- For the details section shall we mention that the setting to FALSE until the last step (when we set to TRUE) applies in the modular case only?
- For the example,might be nice to make the example dataset a bit longer (with some variable values)?
apply_cut.R:
- Should we reference what the datacut flagging variables are normally called as part of the documentation?
process_cut.R:
- Based on Kieran's comments shall we also specify what to put if we don't have a domain for a particular cut type?
- Shall we clarify that the dataset_cut dataset is part of the final list?