Update for admiral 1.0

Question

Update for admiral 1.0

Closed this issue 9 months ago · 4 comments

jeffreyad commented 9 months ago

Answer 1 · 2023-12-11T12:55:33.000Z

is this just for PK or for ADSL as well?

Answer 2 · 2023-12-11T16:58:28.000Z

is this just for PK or for ADSL as well?

@bms63 This is mainly for PK to add the join_type parameters in derive_vars_joined() but I will check ADSL as well to see if anything needs an update.

Answer 3 · 2023-12-11T17:56:08.000Z

many thanks!! Maybe the death cause stuff should be looked at ... not sure if that is in the e2e example.

also good to check for deprecation

Answer 4 · 2023-12-11T17:59:06.000Z

many thanks!! Maybe the death cause stuff should be looked at ... not sure if that is in the e2e example.

also good to check for deprecation

Yes, I'll take a look at those