Update for admiral 1.0
Closed this issue · 4 comments
jeffreyad commented
Update for admiral 1.0
bms63 commented
is this just for PK or for ADSL as well?
jeffreyad commented
is this just for PK or for ADSL as well?
@bms63 This is mainly for PK to add the join_type
parameters in derive_vars_joined()
but I will check ADSL as well to see if anything needs an update.
bms63 commented
many thanks!! Maybe the death cause stuff should be looked at ... not sure if that is in the e2e example.
also good to check for deprecation
jeffreyad commented
many thanks!! Maybe the death cause stuff should be looked at ... not sure if that is in the e2e example.
also good to check for deprecation
Yes, I'll take a look at those