pharmaverse/metatools

Not all rows merged with `combine_supp()`

Closed this issue · 2 comments

billdenney commented

I have a dataset where there is a VISITNUM of 24.04, and it is silently not merging with the supplementary data. I'm looking into this more, but the first issue that I see is the fact that a missing merge is silent.

I'm going to make a PR for this shortly.

statasaurus commented

@billdenney could you try this again from the version currently on main? There have been some bug fixes to combine_supp() on main and so it might fix this. If not I would love to have a pull request
thanks Christina

billdenney commented

@statasaurus , I tried main, too. I made a PR that makes sure that there is a complete merge (and raises an error if not).

I'm still trying to determine why the merge is failing for my specific data, and hopefully another issue and PR will come for that. (My guess for the other issue is that it is a floating point imprecision issue with the number 24.04 being loaded from an xpt file vs being converted from a string.)