pharring/EditorGuidelines

Add ARM support

pharring opened this issue · 4 comments

pharring commented

Commenter Erik Martines Sanches requested an ARM version.

Documentation is here: https://learn.microsoft.com/en-us/visualstudio/extensibility/arm64/target-arm64-visual-studio-extension?view=vs-2022#add-a-visual-studio-2022-target-arm64

Looks like we just have to update the extension manifest.

pharring commented

I can add the manifest, but I don't have access to an ARM box to test it.

  • 👍1
erikmartinessanches commented

It's working, thanks.

  • 👍1
erikmartinessanches commented

Ok it worked on the VS2022 Preview. However, after removing the preview and installing the regular (non-preview) Microsoft Visual Studio Enterprise 2022 (ARM 64-bit) version 17.4.3, I'm not able to install this extension.

install log

2023-01-04 09:27:07 - Microsoft VSIX Installer
2023-01-04 09:27:07 - -------------------------------------------
2023-01-04 09:27:07 - vsixinstaller.exe version:
2023-01-04 09:27:07 - 17.4.2119
2023-01-04 09:27:07 - -------------------------------------------
2023-01-04 09:27:07 - Command line parameters:
2023-01-04 09:27:07 - C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\VSIXInstaller.exe,C:\Users\Erik\Downloads\EditorGuidelines (1).vsix
2023-01-04 09:27:07 - -------------------------------------------
2023-01-04 09:27:07 - Microsoft VSIX Installer
2023-01-04 09:27:07 - -------------------------------------------
2023-01-04 09:27:09 - Initializing Install...
2023-01-04 09:27:10 - Extension Details...
2023-01-04 09:27:10 - 	Identifier         : Editor_Guidelines.Microsoft Corp..123716ef-b2ed-4fab-bbcf-1d5f84856ca3
2023-01-04 09:27:10 - 	Name               : Editor Guidelines
2023-01-04 09:27:10 - 	Author             : Paul Harrington
2023-01-04 09:27:10 - 	Version            : 2.2.9
2023-01-04 09:27:10 - 	Description        : Adds vertical column guides to the Visual Studio text editor.
2023-01-04 09:27:10 - 	Locale             : en-US
2023-01-04 09:27:10 - 	MoreInfoURL        : https://marketplace.visualstudio.com/items?itemName=PaulHarrington.EditorGuidelines
2023-01-04 09:27:10 - 	InstalledByMSI     : False
2023-01-04 09:27:10 - 	SupportedFrameworkVersionRange : [4.5,)
2023-01-04 09:27:10 - 
2023-01-04 09:27:10 - 	SignatureState     : Unsigned
2023-01-04 09:27:10 - 	Supported Products : 
2023-01-04 09:27:10 - 		Microsoft.VisualStudio.Community
2023-01-04 09:27:10 - 			Version : [14.0,17.0)
2023-01-04 09:27:10 - 			ProductArchitecture : x86
2023-01-04 09:27:10 - 
2023-01-04 09:27:10 - 	References         : 
2023-01-04 09:27:10 - 	Prerequisites      : 
2023-01-04 09:27:10 - 		-------------------------------------------------------
2023-01-04 09:27:10 - 		Identifier   : Microsoft.VisualStudio.Component.CoreEditor
2023-01-04 09:27:10 - 		Name         : Visual Studio core editor
2023-01-04 09:27:10 - 		Version      : [15.0,)
2023-01-04 09:27:10 - 
2023-01-04 09:27:10 - Signature Details...
2023-01-04 09:27:10 - 	Extension is not signed.
2023-01-04 09:27:10 - 
2023-01-04 09:27:10 - Searching for applicable products...
2023-01-04 09:27:10 - Found installed product - Global Location
2023-01-04 09:27:10 - Found installed product - Visual Studio Enterprise 2022
2023-01-04 09:27:10 - VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.
   at VSIXInstaller.ExtensionService.GetInstallableDataImpl(IInstallableExtension extension, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
   at VSIXInstaller.ExtensionService.GetInstallableData(String vsixPath, String extensionPackParentName, Boolean isRepairSupported, IStateData stateData, IEnumerable`1& skuData)
   at VSIXInstaller.ExtensionPackService.IsExtensionPack(IStateData stateData, Boolean isRepairSupported)
   at VSIXInstaller.ExtensionPackService.ExpandExtensionPackToInstall(IStateData stateData, Boolean isRepairSupported)
   at VSIXInstaller.App.Initialize(Boolean isRepairSupported)
   at VSIXInstaller.App.Initialize()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
pharring commented

That's because you're trying to install the VS 2019 version.
Install this one: https://marketplace.visualstudio.com/items?itemName=PaulHarrington.EditorGuidelinesPreview
(I know it has "Preview" in the name)
This is because we have to have separate VSIX's for VS 2019 and VS 2022 and the Marketplace doesn't support multiple VSIX's in a single listing.

  • 👍1